Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some partials displayed multiple times on horizontal layout #1090

Closed
1 task done
Danielku15 opened this issue Jan 7, 2023 · 1 comment · Fixed by #1091
Closed
1 task done

Some partials displayed multiple times on horizontal layout #1090

Danielku15 opened this issue Jan 7, 2023 · 1 comment · Fixed by #1091
Assignees
@Danielku15
Labels
area-rendering Everything related to the rendering platform-all Affects all platforms 🕷️ type-bug state-accepted This is a valid topic to work on.
Projects
AlphaTab 1.3

Comments

@Danielku15
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Some partials are displayed double with wrong 0/0 positions in horizontal mode.
image

Expected Behavior

Clean display of all bars only once.

Steps To Reproduce

  1. Open the attached file in alphaTab having the horizontal layout active 61d9c385-ab20-4587-9a28-ef90ad3b8468.zip

Link to jsFiddle, CodePen, Project

No response

Found in Version

1.2

Platform

Web

Environment

- **OS**: Windows 11 Home 22H2
- **Browser**: Chrome 108

Anything else?

No response
@Danielku15 Danielku15 added the state-needs-triage Bug not triaged yet. label Jan 7, 2023
@Danielku15 Danielku15 self-assigned this Jan 7, 2023
@Danielku15 Danielku15 added 🕷️ type-bug area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. platform-all Affects all platforms and removed state-needs-triage Bug not triaged yet. labels Jan 7, 2023
@Danielku15 Danielku15 mentioned this issue Jan 7, 2023
Merged
6 tasks
@Danielku15
Copy link
Member Author

Found the problem. It has to do with the new placeholder mechanism and some legacy code signaling empty results at the end. Due to this mix some old content from a previous render run is not cleared. This bug mainly appears when switching songs and/or layouts.

@Danielku15 Danielku15 added this to Done in AlphaTab 1.3 Jan 7, 2023
@Danielku15 Danielku15 mentioned this issue Feb 11, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Danielku15 Danielku15

Labels
area-rendering Everything related to the rendering platform-all Affects all platforms 🕷️ type-bug state-accepted This is a valid topic to work on.
Projects
Version 1.3
Status: Done
AlphaTab 1.3
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure we do not signal the UI facade for empty partials CoderLine/alphaTab
1 participant
@Danielku15