Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master Volume not working #399

Closed
MDoder97 opened this issue Sep 7, 2020 · 6 comments
Closed

Master Volume not working #399

MDoder97 opened this issue Sep 7, 2020 · 6 comments
Assignees
Labels
area-player Related to the audio playback engine. platform-javascript Related to the JavaScript version of alphaTab platform-net Related to the .net version of alphaTab 🕷️ type-bug state-accepted This is a valid topic to work on.
Milestone

Comments

@MDoder97
Copy link

MDoder97 commented Sep 7, 2020

Your environment

VSCode

  • Version used: (master branch)
  • Platform used: JavaScript
  • Browser Name and Version: Chrome
  • Operating System and version Desktop

Expected Results

Connected master volume to the slider, it didn't work however. I then tried to just call api.masterVolume = 0 right after api initialization, still nothing.

i'm including script from cdn - https://cdn.jsdelivr.net/npm/@coderline/alphatab@latest/dist/alphaTab.js

Code i used

const settings = {
  file: 'https://www.alphatab.net/files/canon.gp',
  player: {
    enablePlayer: true,
    soundFont:
      'https://cdn.jsdelivr.net/npm/@coderline/alphatab@latest/dist/soundfont/sonivox.sf2',
  },
};
const api = new alphaTab.AlphaTabApi(tab, settings);
api.masterVolume = 0;
@cheap-glitch
Copy link

You need to call updateSettings to apply the changes:
https://www.alphatab.net/docs/reference/api/updatesettings/

@MDoder97
Copy link
Author

MDoder97 commented Sep 8, 2020

If you mean calling it right after i set masterVolume, still doesn't work, also with slider it causes significant lag as it gets updated often. PlaybackSpeed works just fine without udateSettings with slider right out of the gate though.

@Danielku15 Danielku15 self-assigned this Sep 8, 2020
@Danielku15 Danielku15 added state-needs-investigation 🕷️ type-bug area-player Related to the audio playback engine. platform-javascript Related to the JavaScript version of alphaTab platform-net Related to the .net version of alphaTab priority-high state-accepted This is a valid topic to work on. and removed state-needs-investigation labels Sep 8, 2020
@Danielku15 Danielku15 added this to the 1.1 milestone Sep 8, 2020
@Danielku15 Danielku15 added this to In progress in AlphaTab 1.1 Sep 8, 2020
@Danielku15
Copy link
Member

I can confirm that this is a bug. I just checked the sequence and there is a missing unit conversion missing for the master volume. I will try to provide a fixed version this evening.

AlphaTab 1.1 automation moved this from In progress to Done Sep 9, 2020
@Danielku15
Copy link
Member

I didn't manage to sit down yesterday to add the required change. So with 1 day delay the fix is available 😉

@MDoder97
Copy link
Author

MDoder97 commented Sep 9, 2020

Thanks! Is it available with 1.1 release though or right now? I'm pulling the latest from cdn and it still doesn't work here. Sorry if i'm missing something. :)

@Danielku15
Copy link
Member

It is available via 1.1.0+alpha.42, either you use this version or the alpha tag for early access.

https://www.npmjs.com/package/@coderline/alphatab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-player Related to the audio playback engine. platform-javascript Related to the JavaScript version of alphaTab platform-net Related to the .net version of alphaTab 🕷️ type-bug state-accepted This is a valid topic to work on.
Projects
No open projects
AlphaTab 1.1
  
Done
Development

No branches or pull requests

3 participants