Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement:] More API endpoints of LevelLockHandler #86

Closed
2 of 3 tasks
pupnewfster opened this issue May 6, 2018 · 0 comments
Closed
2 of 3 tasks

[Enhancement:] More API endpoints of LevelLockHandler #86

pupnewfster opened this issue May 6, 2018 · 0 comments

Comments

@pupnewfster
Copy link
Collaborator

pupnewfster commented May 6, 2018

Some eventual API endpoints that could be useful for LevelLockHandler

  • getLockByFuzzyKey(FuzzyLockKey key) Would allow people to retrieve specific fuzzy locks without having to register them against a specific type for creation.
  • Modify <T> RequirementHolder getLocks(Class<? extends T> classType, T toCheck) or create a new method that supports multiple objects to check and builds up the RequirementHolder. <T> RequirementHolder getLocks(Class<? extends T> classType, T... toCheck) would probably be the declaration. Use case would be being able to pass all the materials of a tinker's tool directly to getLocks instead of having to calculate them and combine them manually.
  • Create and support a LockKey type for multiple levels of data. Example would be with being able to use point 2 and have the Tinker's materials also be able to register the fact they want to check a set of Locks (based on the traits that the different materials have). It probably would be best if this implementation allowed using getLocks so that it can expand to even more lock types.
@pupnewfster pupnewfster added this to the Eventually milestone May 6, 2018
@pupnewfster pupnewfster self-assigned this May 6, 2018
Lanse505 added a commit that referenced this issue May 7, 2018
@pupnewfster pupnewfster modified the milestones: Eventually, 1.6.0 May 21, 2018
Lanse505 added a commit that referenced this issue May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant