Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating nth-check 2.0.1 #93

Merged
merged 2 commits into from
May 5, 2022
Merged

Updating nth-check 2.0.1 #93

merged 2 commits into from
May 5, 2022

Conversation

ClaudiaMoPr
Copy link
Contributor

nth-check has been updated to 2.0.1 version in package.json

@ClaudiaMoPr ClaudiaMoPr self-assigned this Apr 22, 2022
tramuntanal
tramuntanal requested changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are forgetting to commit the package-lock.json after building the JS packages.

@ClaudiaMoPr ClaudiaMoPr merged commit b0fb121 into master May 5, 2022
@ClaudiaMoPr ClaudiaMoPr deleted the nthcheck_update_2.0.1 branch May 5, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tramuntanal tramuntanal tramuntanal approved these changes

@laurajaime laurajaime Awaiting requested review from laurajaime

Assignees

@ClaudiaMoPr ClaudiaMoPr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ClaudiaMoPr @tramuntanal