Introduce treemending work-around for pnpm

[kaisalmen]

@CGNonofr Patching directly doesn't work with pnpm. Every file of every used node_modules is contained in a data store. Patching files directly does not work. I debugged it locally, during the patch process suddenly files have already been patched and the patch process stops. My wild guess is that the file traversal is not consistent. 🤷‍♂️

Anyway, when a .pnpm directory is detected in monaco-editor path this workaround copies all esm files to a tmp dir patches everything and copies files back. This works in nicely in my test pnpm project.

[CGNonofr]

I'm not familiar with pnpm, how does it help patching it elsewhere?

[kaisalmen]

It uses a datastore in your home directory, so you don't have any node_modules twice. The files in node_modules are linked/virtual. This makes problems during the patch process. Copying forth and back seems reliable. I came to this approach because pnpm patch creates a tmp directory where you apply changes and then the commit step moves it back.

It don't really like tool specific work arounds, but this is the one with least impact, IMO

[kaisalmen]

Btw, with this in place treemending as postinstall works with monaco-languageclient with npm, yarn and pnpm.

[CGNonofr]

Feel like a hack to me, I hope it won't introduces other issues

maybe the patch approach is still not the best way...

Let's merge it and think about a better solution

[kaisalmen]

Feel like a hack to me, I hope it won't introduces other issues

Yes, I can't disagree 😎 I will test it later today with a new next release of monaco-languageclient.

[kaisalmen]

maybe the patch approach is still not the best way...

From the possibilities we have (monaco fork, polyfills) it is the best option.

[CGNonofr]

btw, can't https://pnpm.io/npmrc#public-hoist-pattern help us instead?

[kaisalmen]

Resolution is not the problem, but file traversal. I always ended up with files that were already patched although they were untouched before. It is really weird. It patched let's say 50 files and suddenly one was already patched. Ahhh, maybe it is contained twice and then the datastore stores it only once and then boom

[CGNonofr]

reading about package-import-method, it seems that by default it uses a cloning mode, is this the issue? doesn't it fail when it's not supported? it says it doesn't work on mac

maybe switching to copy fix the issue (but it probably has a cost)

[kaisalmen]

maybe switching to copy fix the issue (but it probably has a cost)

then every pnpm user has to configure something.

That we have different tools doing the same, but not behaving consistent is the real issue, isn't it? 😉

[kaisalmen]

@CGNonofr It works fine with https://www.npmjs.com/package/monaco-languageclient/v/6.0.3