Skip to content
This repository has been archived by the owner on Jun 24, 2019. It is now read-only.

User Sign Up Mutation #9

Open
charlesjliu opened this issue Sep 15, 2018 · 6 comments
Open

User Sign Up Mutation #9

charlesjliu opened this issue Sep 15, 2018 · 6 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@charlesjliu
Copy link
Collaborator

Acceptance Criteria

  • Mutation exists that would be called from the frontend when a new User signs up
  • This is for sign ups that do not come from OAuth
  • Complimentary jest tests

Refer to Information Architecture:
https://docs.google.com/document/d/1e8zcV_XsasGlhcxcOVCcRXwkqpxgCot4PvWog3ynE_Q/edit#heading=h.x9hh4idplmff

@jagzviruz
Copy link
Member

I recommend using email address as the username, and then have a field for display name. People who signup with email can later link their Social profiles, if they match on the email id. Similarly if people signup with social and later wish to detach it and use email id and password, it should be easier to retrieve their profile.

@jagzviruz jagzviruz added the good first issue Good for newcomers label Sep 17, 2018
@jagzviruz jagzviruz added this to the MVP 0 milestone Sep 17, 2018
@tarang9211
Copy link

I'm new to this, but I'd be interested in taking this up with @jagzviruz's help.

@jagzviruz
Copy link
Member

I'm new to this, but I'd be interested in taking this up with @jagzviruz's help.

@gibsonhan has an initial PR #16 that describes the mongoose schema. @tarang9211 Can you work with him to complete the mutations and resolver

@gibsonhan
Copy link
Contributor

@tarang9211 I'll message you on slack

@charlesjliu
Copy link
Collaborator Author

Closing this, looks like a duplicate

@charlesjliu charlesjliu reopened this Oct 4, 2018
@charlesjliu
Copy link
Collaborator Author

Nope, nevermind I misread the acceptance criteria for #12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants