Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to edit mentorship request #795

Open
moshfeu opened this issue Jun 11, 2021 · 10 comments
Open

Allow to edit mentorship request #795

moshfeu opened this issue Jun 11, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request wip Work in progress

Comments

@moshfeu
Copy link
Member

moshfeu commented Jun 11, 2021

Allow mentees to cancel / edit mentorship request.

If anyone is willing to take this and need more explanations, I'll add them.

@moshfeu moshfeu added enhancement New feature or request help wanted Extra attention is needed labels Jun 11, 2021
@brentmclark
Copy link
Collaborator

@moshfeu I'll grab this.

@brentmclark brentmclark self-assigned this Jun 15, 2021
@moshfeu
Copy link
Member Author

moshfeu commented Jun 15, 2021

Thank you!
May hold on a bit because I'm changing basically all the files in the project as part of #802 .

I'll find a stable point, merge to master then you could checkout and I'll continue.

Let's start with the server side if sounds good?

@moshfeu
Copy link
Member Author

moshfeu commented Jun 22, 2021

I finished the first phase of moving to typescript. I'll take a break from it so we could work on other tasks and will complete typescript once we will be more stablize (new code will be in ts of course)

@moshfeu moshfeu self-assigned this Jun 24, 2021
@moshfeu moshfeu added wip Work in progress and removed help wanted Extra attention is needed labels Jun 24, 2021
@ojalmaps
Copy link

ojalmaps commented Sep 2, 2021

It will great if this feature is implemented 👍

@moshfeu
Copy link
Member Author

moshfeu commented Sep 2, 2021

It will great if this feature is implemented 👍

Hi @ojalmaps ,
Are you talking about the edit mentorship part?

@ojalmaps
Copy link

ojalmaps commented Sep 2, 2021

I am talking about the cancel mentorship part.

@moshfeu
Copy link
Member Author

moshfeu commented Sep 2, 2021

This is already implemented.

Screen Shot 2021-09-02 at 19 25 42

Notice, the cancel button is only when mentor hasn't respond to the request yet.
Once the mentor approved, the cancellation should be "face to face".

Makes sense?

@moshfeu moshfeu changed the title Allow to cancel / edit mentorship request Allow to edit mentorship request Sep 9, 2021
@KravMaguy
Copy link

KravMaguy commented May 23, 2022

I had this happen to me the other day, I thought I would look for a mentor on the site. I sent a request but after I sent it I wanted to edit some details in the request, I didnt see that option so I cancelled the request. Now when I click on the mentor the form fields are filled with the last request but If i try to send it just gives me a toast saying a request already exists, (suspended in a cancelled state).. is that the desired behavior, or should we fix it?

@moshfeu
Copy link
Member Author

moshfeu commented May 23, 2022

I believe we should fix it. Note that the change should be in both the client and the server.
We should also think about the user experience. How / where the user will be able the edit a request.

@KravMaguy
Copy link

KravMaguy commented May 27, 2022

If anyone is willing to take this and need more explanations, I'll add them.

I could be of some help if I knew how to set up the project. my atlas does not populate. we have custom start scripts though they are not discussed in the readme, not sure if these are relevant. I tried "yarn user:import" but it crash. gitpod for quick start is mentioned in client readme but it doenst work if you need server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip Work in progress
Projects
None yet
Development

No branches or pull requests

4 participants