Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for proxies and CLI applications #51

Merged
merged 2 commits into from
Jan 9, 2021

Conversation

jlubeck
Copy link
Contributor

@jlubeck jlubeck commented Jan 8, 2021

Basically what the title says. Simple changes, which expand the possibilities of the package.

@@ -14,8 +13,8 @@ class RequestData {
Encoding encoding;

RequestData({
@required this.method,
@required this.baseUrl,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, just a question, why did you remove the @required decorator here?

@jlubeck
Copy link
Contributor Author

jlubeck commented Jan 9, 2021 via email

@CodingAleCR
Copy link
Owner

Yes, it definitely should not be flutter foundation import. I probably missed it when I changed the different @required decorators to be from the meta plugin. This plugin allows you to work with CLI applications. I'll add it it the future since as you said there's not much of a difference in terms of functionality, it's more of a semantics issue.

Thanks and great work!

@CodingAleCR CodingAleCR merged commit 94cfcae into CodingAleCR:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants