Adds QR-CODE API to request the latest Poll-URL via QR-Code #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To retrieve the host address i'am using this code within route in I am not entirely sure that this works with the way of hosting and that the correct url to the server can be determined. Also it's hardcoded to use http instead of https. Maybe this must be changed. |
|
I'm going to go ahead and merge this and we can sort out #96 separately! |
This was referenced May 17, 2021
shiffman
pushed a commit
that referenced
this pull request
May 25, 2021
* new options-button styling with hover effect * moves everthing into a MAIN tag * fixes some cross effects * adds hover effect to vote button, fixes hover effects on selections * fix * fix * textf-flow on poll-result view back to left orientated. to free up space on livestreams / overlays * implement a qrcode api with the url to the newest poll * removes authentification on qrcode to be able to display it within OBS * Delete package-lock.json * Delete package.json * Revert "Delete package.json" This reverts commit bf99793. * fixes package.json * saves styling parameters from url-query within a template data-attribute * adds styling via url-params to all routes * add missing options view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QR-CODE API
This adds a new route and functionality to the API
/qrcodeThis will response with a page with a qr-code including the URL to the newest poll. In this way, viewers can simply scan the code to take part in the voting.
The qr-code page provides an forced transparent background, in this way it is perfect for use in OBS.
For demo purposes, the QR code in the screenshot leads to my own website. In production it contains the url for the newest poll.RESPONSIVE DESIGN
I added a responsive design to the voting page. Users who have followed the qr-code get an optimized display for voting, with larger buttons and more space around / between them.
To prevent merge conflicts, all style changes are in PR #95
Greetings Andi