Skip to content
This repository has been archived by the owner on Jul 5, 2022. It is now read-only.

Add addtional info for screen readers #858

Merged
merged 1 commit into from Feb 10, 2019
Merged

Conversation

bjorvack
Copy link
Contributor

fixes #837

Added aria-label attributes to video cards with a hidden span as fallback

@vimkat vimkat added Website accessibility Issues related to WCAG compliance labels Nov 22, 2018
@vimkat
Copy link
Member

vimkat commented Nov 22, 2018

Still, I don't really like this solution since it feels a little bit "hacky" to add those hidden spans (remembers me of the old days with IE6) but if it helps and works reliably, I'm totally OK with it.

I just have a small question: When a screen reader supports the aria-label attribute does it also read the hidden span and therefore the description twice? Or does aria-label always replace the link text? If that is not the case, I think we should remove the aria-label when a hidden span is used to prevent that behaviour.

@bjorvack
Copy link
Contributor Author

bjorvack commented Nov 22, 2018

aria-label replaces the content of the tag as far as I know. The problem is that not all screenreaders are compatible with all the tags yet. It's a bit like mail clients and HTML 5.

Could be handy for research: https://www.powermapper.com/tests/screen-readers/labelling/a-aria-label/
Gives a great overview which attributes are supported decently

@vimkat
Copy link
Member

vimkat commented Nov 22, 2018

Thanks for sharing this!
Alright, so I think we can merge then? Is that OK with you, @shiffman?

@gruselhaus gruselhaus requested review from shiffman and removed request for shiffman January 25, 2019 18:03
@meiamsome meiamsome merged commit afd1fa7 into CodingTrain:master Feb 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Issues related to WCAG compliance Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple of the same buttons - accessibility issue
3 participants