Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to pip package with pyproject.toml #141

Merged
merged 7 commits into from Jul 27, 2023

Conversation

patryk-kowalski-ds
Copy link
Contributor

@patryk-kowalski-ds patryk-kowalski-ds commented Jul 26, 2023

PR Type:
Refactoring


PR Description:
This PR transitions the project from using a requirements.txt file for dependency management to using a pyproject.toml file. This change allows for more robust package management and makes the project more compatible with modern Python packaging tools. The PR also updates the Dockerfiles to reflect this change.


PR Main Files Walkthrough:
-setup.py: Added a setup function for compatibility with legacy tools.
-Dockerfile.github_action: Replaced the addition and installation of requirements.txt with pyproject.toml.
-docker/Dockerfile: Similar changes as in Dockerfile.github_action.
-docker/Dockerfile.lambda: Replaced the addition and installation of requirements.txt with pyproject.toml and updated the version of mangum.
-pyproject.toml: Added a comprehensive project configuration including build system, project details, dependencies, and scripts.
-requirements.txt: Removed all specific dependencies and replaced with a reference to the local directory.

@patryk-kowalski-ds
Copy link
Contributor Author

/describe

@github-actions github-actions bot changed the title Pg/pip package Transition to pip package Jul 26, 2023
@patryk-kowalski-ds
Copy link
Contributor Author

/review

@github-actions
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Transition to pip package
  • 📌 Type of PR: Refactoring
  • 🧪 Relevant tests added: No
  • Focused PR: Yes, the PR has a clear and coherent title and description, and all PR code diff changes are properly derived from the title and description.
  • 🔒 Security concerns: No, the PR does not introduce any obvious security concerns. However, it's always a good practice to ensure all dependencies are up-to-date to avoid potential vulnerabilities in older versions.

PR Feedback

  • 💡 General PR suggestions: The PR is well-structured and the transition to a pip package is a good improvement for the project. However, it would be beneficial to add tests to ensure that the transition does not break any existing functionality. Additionally, the authors and maintainers in the pyproject.toml file are placeholders and should be replaced with the actual authors and maintainers.

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve: Suggest improvements to the code in the PR. These will be provided as pull request comments, ready to commit.
/ask <QUESTION>: Pose a question about the PR.

@patryk-kowalski-ds
Copy link
Contributor Author

The authors/maintainers should be filled in, we left it empty

@mrT23 mrT23 requested a review from okotek July 26, 2023 16:18
@mrT23
Copy link
Collaborator

mrT23 commented Jul 27, 2023

Changelog updates:

2023-07-27

Changed

  • Transitioned the project from using a requirements.txt file for managing dependencies to using a pyproject.toml file, making the project a pip package for better dependency management.
  • Updated Dockerfiles to install dependencies from pyproject.toml instead of requirements.txt.
  • Updated the version of mangum in Dockerfile.lambda.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog -commit'

@okotek
Copy link
Contributor

okotek commented Jul 27, 2023

/describe

@github-actions github-actions bot changed the title Transition to pip package Transition to pip package with pyproject.toml Jul 27, 2023
setup.py Outdated Show resolved Hide resolved
@okotek
Copy link
Contributor

okotek commented Jul 27, 2023

Thank you for your contribution @patryk-kowalski-ds

@okotek okotek merged commit d375dd6 into Codium-ai:main Jul 27, 2023
1 check passed
yochail pushed a commit to yochail/pr-agent that referenced this pull request Feb 11, 2024
Transition to pip package with pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants