Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blacklist for Non-Editable File Extensions in Documentation #385

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

hussam789
Copy link
Collaborator

@hussam789 hussam789 commented Oct 17, 2023

PR Type:

Enhancement


PR Description:

  • This PR addresses the issue of adding documentation to non-editable file extensions like SQL, YAML, etc.
  • A blacklist of such file extensions has been added to prevent the addition of inline documentation to these files.
  • The changes are mainly in the 'pr_agent/tools/pr_add_docs.py' and 'pr_agent/settings/language_extensions.toml' files.

PR Main Files Walkthrough:

files:

pr_agent/tools/pr_add_docs.py: Added a check to disable adding docs to scripts and other non-relevant text files. The blacklist of extensions is fetched from the settings.
pr_agent/settings/language_extensions.toml: Added a new section 'docs_blacklist_extensions' to list the file extensions for which documentation should not be added.

@hussam789 hussam789 requested a review from mrT23 October 17, 2023 15:55
@github-actions
Copy link
Contributor

PR Analysis

  • 🎯 Main theme: Adding a blacklist of file extensions to prevent adding docs to scripts and other non-relevant text files.
  • 📝 PR summary: This PR introduces a new feature that allows the system to avoid adding documentation to scripts and other non-relevant text files. This is achieved by adding a blacklist of file extensions to the system's settings.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 2, because the PR is small and straightforward, but it's important to ensure that the new feature doesn't introduce any unexpected behavior.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: It would be beneficial to add tests that verify the new functionality. This would help ensure that the system behaves as expected when encountering files with blacklisted extensions.

  • 🤖 Code feedback:

How to use

To invoke the PR-Agent, add a comment using one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@mrT23
Copy link
Collaborator

mrT23 commented Oct 19, 2023

/describe --pr_description.extra_instructions="use bullet points in 'PR Description' section"

@github-actions github-actions bot changed the title Add docs editable blacklist of file extensions like sql, yaml... Add Blacklist for Non-Editable File Extensions in Documentation Oct 19, 2023
@github-actions github-actions bot added the enhancement New feature or request label Oct 19, 2023
@hussam789 hussam789 merged commit 1b6fb3e into main Oct 19, 2023
3 checks passed
@hussam789 hussam789 deleted the hl/fix_add_docs_in_scripts branch October 19, 2023 08:21
@UjjawalKRoy
Copy link

Preparing PR description...

@UjjawalKRoy
Copy link

Preparing review...

1 similar comment
@UjjawalKRoy
Copy link

Preparing review...

yochail pushed a commit to yochail/pr-agent that referenced this pull request Feb 11, 2024
…ripts

Add Blacklist for Non-Editable File Extensions in Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants