-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle to automatically enable /improve --extended
#569
Add toggle to automatically enable /improve --extended
#569
Conversation
PR Description updated to latest commit (c2b0891) |
PR Analysis
PR Feedback💡 General suggestions: The PR is well-structured and the changes are clear. It would be beneficial to add tests to validate the new functionality and ensure it doesn't break existing features. Also, consider handling exceptions more specifically rather than using a general catch-all. 🤖 Code feedback:
✨ Usage tips:
|
this looks good :-) This kind of limitation to prevent "explosion" of calls in edge cases is important |
…e_extended_simple Add toggle to automatically enable `/improve --extended`
Type
Enhancement
Description
_get_is_extended
inpr_agent/tools/pr_code_suggestions.py
to check if the extended mode should be enabled by the--extended
flag or automatically based on the configuration.pr_agent/tools/pr_code_suggestions.py
to prevent reducing the number of suggestions below a certain threshold.docs/IMPROVE.md
) to include the newauto_extended_mode
configuration parameter.auto_extended_mode
to the settings file (pr_agent/settings/configuration.toml
).PR changes walkthrough
1 files
pr_code_suggestions.py
pr_agent/tools/pr_code_suggestions.py
The PR introduces a new method
_get_is_extended
todetermine if the extended mode should be enabled either by
the
--extended
flag or automatically according to theconfiguration. It also modifies the logic for reducing the
number of suggestions, ensuring it doesn't go below a
certain threshold.
1 files
IMPROVE.md
docs/IMPROVE.md
The documentation is updated to include the new
auto_extended_mode
configuration parameter.1 files
configuration.toml
pr_agent/settings/configuration.toml
A new configuration parameter
auto_extended_mode
is addedto the settings file.
User description
Simpler version of #564 without all the extra thresholds, and keeping the default as
false
for backwards compatibility.