Make the build reproducible #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0], I noticed that guidata could not be built reproducibly. This is due to the testsuite not completely cleaning up after itself, so these files get installed into the guidata Debian package. However, as they create nondetermistic contents this makes the package unreproducible. I originally filed this in Debian as bug #1041842 [1]. The patch is slightly different there as I didn't notice the conditional block until now; this patch should be prefered instead. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/1041842
PierreRaybaut
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the Reproducible Builds effort, I noticed that guidata could not be built reproducibly.
This is due to the testsuite not completely cleaning up after itself, so these files get installed into the guidata Debian package. However, as they create nondeterministic contents this makes the package unreproducible.
I originally filed this in Debian as bug #1041842. The patch is slightly different there as I didn't notice the conditional block until now; this patch should be preferred instead.