Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use 'req@url' syntax to install from remote VCS #364

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented Feb 11, 2023

Use 'req@url' syntax when using pip to install from a remote git repository over 'url#egg=req' to avoid the use of #egg= fragments with a non-PEP 508 name. This will be required in pip v25.0+.

Also use pip's git+https VCS scheme over git+git as recommended in the pip docs on VCS Support:

The use of git, git+git, and git+http schemes is discouraged. The former two use the Git Protocol, which lacks authentication, and HTTP is insecure due to lack of TLS based encryption.

@matthewfeickert
Copy link
Contributor Author

@oshadura this is ready for review. Let me know if you have any questions. 👍

* Use 'req@url' syntax when using pip to install from a remote git
  repository over 'url#egg=req' to avoid the use of #egg= fragments
  with a non-PEP 508 name. This will be required in pip v25.0+.
   - c.f. pypa/pip#11617 for more details.
* As recommended in the pip docs on VCS Support:
  > The use of git, git+git, and git+http schemes is discouraged.
  > The former two use the Git Protocol, which lacks authentication,
  > and HTTP is insecure due to lack of TLS based encryption.
   - c.f. https://pip.pypa.io/en/stable/topics/vcs-support/
@oshadura oshadura merged commit b13360c into CoffeaTeam:master Feb 13, 2023
@oshadura
Copy link
Member

Many thanks!

@matthewfeickert matthewfeickert deleted the fix/use-req-url-syntax branch February 13, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants