Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for PHYSLITE schema #540

Closed
4 of 9 tasks
nikoladze opened this issue Jun 7, 2021 · 1 comment
Closed
4 of 9 tasks

Tracking issue for PHYSLITE schema #540

nikoladze opened this issue Jun 7, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@nikoladze
Copy link
Contributor

nikoladze commented Jun 7, 2021

This is to track the TODO list/open questions for the PHYSLITE schema for nanoevents

  • Port ElementLink handling to awkward dask fix: Daskify Elementlinks in PHYSLITE schema #872
  • Add a test for a simple selection procedure involving several collections
  • Continue with global index forms or to use a different approach? Use eventindex instead of global index form for PHYSLITE schema #541
  • Complete the list of mixin classes and add important methods
  • Make Records of Unions instead of Unions of Records for the cases with links into multiple collections? (maybe better try not to make unions at all, e.g. for truth collection create a homogeneous record)
  • Find out why ak.where triggers materialization of a few (but not all) columns (probably different situation now with dask)
  • Silence warnings or add a filter function to be passed to TBranch.iteritems
  • Add EventInfo collection and check if there are more non-jagged collections fix: allow for collections that contain non-jagged arrays in PHYSLITE schema #888
  • Zip the HLT collection (this changed in newer PHYSLITE versions, see next point)
  • Find out how trigger info/matching works and how we make it work in columnar analysis
  • Find a way to load the hash to branchname mapping from the MetaData tree (or calculate hash manually) (maybe we better hardcode targets for cases where there is only a single one and make a special treatment for truth collection)
  • Try out what is/isn't working with newer versions of PHYSLITE
  • Some collections (e.g. TruthMuons) have fiels that can't be zipped (empty lists for some events, so can't use common offsets). How to handle this? Have a list of collections not to zip? Don't zip anything at all?
@nikoladze nikoladze added the enhancement New feature or request label Jun 7, 2021
@lgray
Copy link
Collaborator

lgray commented Dec 7, 2023

Seems stale.

@lgray lgray closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants