fix: allow for collections that contain non-jagged arrays in PHYSLITE schema #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikoladze
changed the title
9 tasks
|
merging this since it does not introduce new failures (waiting on awkward fix) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the PHYSLITE schema didn't handle collections that contain both scalars and lists (like
EventInfoandxTrigDecision). This should be now fixed. In addition i also added treatment for branches that are not grouped with anything (newer PHYSLITE files have a branch namedindex_refthat falls in this category).This PR should be possible to merge independently of #872 (i tested it also on top of these changes).