Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update Running inference tools notebook #1004

Merged
merged 3 commits into from Jan 22, 2024

Conversation

Saransh-cpp
Copy link
Contributor

@Saransh-cpp Saransh-cpp commented Jan 22, 2024

I have updated the notebook and have additionally removed all the awkward/dask-awkward comparisons (if I am not wrong, the permit_dask argument was removed and now there is no way to turn dask "off" in coffee?)

Updated notebook: https://github.com/Saransh-cpp/coffea/blob/update-mltools-notebook/binder/mltools.ipynb

@lgray
Copy link
Collaborator

lgray commented Jan 22, 2024

Thanks @Saransh-cpp - having a look.

@lgray
Copy link
Collaborator

lgray commented Jan 22, 2024

@Saransh-cpp

permit_dask=True is now delayed=True and is set default True. There are still cases where people want to play with concrete arrays through nanoevents, but we do not intend for it to be the common case.

Another thing you can remove in the notebook are lines like:

ak = self.get_awkward_lib(return_array, events)

This is no longer needed since now you can call ak.some_function on a dask_awkward.Array and it will call the corresponding dask_awkward function. You should be able to remove those lines and re-evaluate the notebook.

Co-authored-by: lgray <lgray@users.noreply.github.com>
@Saransh-cpp
Copy link
Contributor Author

Thanks for the review!

permit_dask=True is now delayed=True and is set default True. There are still cases where people want to play with concrete arrays through nanoevents, but we do not intend for it to be the common case.

Oh, I see, nice!

I've removed the occurrences of self.get_awkward_lib from the notebook.

@lgray
Copy link
Collaborator

lgray commented Jan 22, 2024

@Saransh-cpp Anything else you'd like to add here?

@Saransh-cpp
Copy link
Contributor Author

Nope, looks ready to me!

@lgray lgray merged commit 9843c0f into CoffeaTeam:master Jan 22, 2024
14 checks passed
@Saransh-cpp Saransh-cpp deleted the update-mltools-notebook branch January 22, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants