New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Do not add trailing slash in xrootd urls #1054
Conversation
@nsmith- can you give this a try? |
b8e5a5a
to
a633fe1
Compare
a633fe1
to
27a81e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should point out that rather than parsing the SITECONF you can also ask rucio to give you the PFNs, e.g. on the commandline
rucio list-file-replicas cms:/SingleMuon/Run2018A-UL2018_MiniAODv2_NanoAODv9_GT36-v1/NANOAOD --rse 'rse_type=DISK&country=US' --protocol root
gives xrootd urls for files in that dataset
@@ -114,7 +124,8 @@ def _get_pfn_for_site(path, rules): | |||
pfn = pfn.replace(f"${i+1}", grs[i]) | |||
return pfn | |||
else: | |||
return rules + "/" + path | |||
# not adding any slash as the path usually starts with it | |||
return rules + path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be sure you could use rules + "/" + path.removeprefix("/")
I agree, but the SITCONF hack was done to overcome the issue that not all the sites are returning |
- Sites_map cache file is invalidated after 10 mins
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
a0dc826
to
644cead
Compare
Is there a ticket/thread with CMS DM ops / site support on the subject? If not, we should make one. |
I will give it another try, it was more than 1 year ago and I haven't test it since then.. |
Now the sites map cache file is invalidated after 10 mins to avoid stale information.
Fixes #1053