Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PFNano additions for NanoEvents #427

Merged
merged 6 commits into from
Apr 2, 2021
Merged

PFNano additions for NanoEvents #427

merged 6 commits into from
Apr 2, 2021

Conversation

nsmith-
Copy link
Member

@nsmith- nsmith- commented Jan 21, 2021

Allows things like:
Screen Shot 2021-01-20 at 10 55 13 PM

Some cross-references aren't yet available in the PFNano file I was using. A complete set would need at least the following: https://gist.github.com/nsmith-/b29c4f4a13214ed65b93bf2d5a65f955

@nsmith-
Copy link
Member Author

nsmith- commented Feb 17, 2021

The naming may change soon: cms-jet/PFNano#29
Also the missing branches have been updated: cms-jet/PFNano#30
Will follow that before merging.

@nsmith-
Copy link
Member Author

nsmith- commented Apr 1, 2021

Merging for now, since rename may be further in the future. Note this PR also fixes #468 by changing the missing cross-reference behavior from (default/optional) exception/warning to warning/pass

@nsmith- nsmith- linked an issue Apr 1, 2021 that may be closed by this pull request
@nsmith- nsmith- marked this pull request as ready for review April 1, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dask doesn't like NanoAODs with bad cross-references
2 participants