Setup speed and more deterministic behavior for jetmet tools #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lgray
commented
Apr 3, 2021
•
lgray
commented
- make instantiating corrected jets faster at the cost of a longer evaluation time
- make instantiating corrected met faster at the cost of a longer evaluation time
- use per-batch deterministic random seed for jet smearing ( fix Deterministic jet smearing #454 )
- investigate and fix reported memory leak in met corrector ( fixed in Actually fix MET cycles #487 )
- investigate and fix Output of FactorizedJetCorrector.getCorrection has too many dimensions #461
|
@JayjeetAtGithub can you see what's going on with this failure of the rados tests? It looks like there's something screwey on the docker side of things. It's not failing in anything related to coffea. |
|
@kondratyevd if you have time - give this a quick look. The instantiation speed is an order of magnitude faster. |
|
@lgray Yeah, I am trying to find the problem |
nsmith-
requested changes
Apr 8, 2021
nsmith-
requested changes
Apr 8, 2021
lgray
force-pushed
the
jetmet_tools_improvements
branch
from
2e2599d
to
7311d3e
Compare
nsmith-
approved these changes
Apr 8, 2021
This was referenced Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.