Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated TreeMakerSchema to create collection from branch_forms #490

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Updated TreeMakerSchema to create collection from branch_forms #490

merged 1 commit into from
Apr 8, 2021

Conversation

yimuchen
Copy link
Contributor

@yimuchen yimuchen commented Apr 8, 2021

  • Update TreeMakerSchema doc string.
  • Remove print statements from collection creation
  • Object collection now generated automatically by branch names.

nsmith-
nsmith- approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@nsmith- nsmith- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nsmith-
Copy link
Member

nsmith- commented Apr 8, 2021

Last test is probably a parsl timeout that we've seen a lot of, going to merge anyway

@nsmith- nsmith- merged commit 1157c53 into CoffeaTeam:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsmith- nsmith- nsmith- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yimuchen @nsmith-