Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to skyhook 0.2.0 and fix failing workflow #532

Merged
merged 11 commits into from
Jun 26, 2021
Merged

Update to skyhook 0.2.0 and fix failing workflow #532

merged 11 commits into from
Jun 26, 2021

Conversation

JayjeetAtGithub
Copy link
Contributor

No description provided.

@JayjeetAtGithub JayjeetAtGithub changed the title update to skyhook 0.2.0 Update to skyhook 0.2.0 and fix failing workflow Jun 1, 2021
@lgray
Copy link
Collaborator

lgray commented Jun 3, 2021

@JayjeetAtGithub something is wrong in your test container, it is trying to build llvmlite from scratch. Please check this out.

@JayjeetAtGithub
Copy link
Contributor Author

Hi @lgray , I am trying to reproduce and fix this issue locally already. It's taking longer than expected.

@lgray
Copy link
Collaborator

lgray commented Jun 7, 2021

No worries - let me know if there's anything I can do.

@lgray
Copy link
Collaborator

lgray commented Jun 25, 2021

Is this PR to be discarded for #545 ?

oshadura
oshadura reviewed Jun 25, 2021
View reviewed changes
tests/test_rados_parquet_job.py
executor_args = {"client": client, "ceph_config_path": "/etc/ceph/ceph.conf"}
executor_args = {
"client": client,
"ceph_config_path": "/tmp/testradosparquetjob/ceph.conf",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayjeetAtGithub with Skyhook 0.2.0 do we still need to have explicitly passing ceph.conf as executor args?
At coffea-casa, we couldn't put ceph.conf in Docker container (security) and we simply mounted Skyhook available through CephFS using kubernetes. Using ceph-fuse is also not possible as well mount because we don't have root access in containers.

cc: @bbockelm @jthiltges @gattebury

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oshadura @lgray I am done doing my changes. We can close this PR and work on the ceph.conf exposure problem separately. This PR mostly fixes a fragile CI script and updates the Skyhook docker image.

@JayjeetAtGithub
Copy link
Contributor Author

JayjeetAtGithub commented Jun 26, 2021 •
edited

Is this PR to be discarded for #545 ?

Closed 545 and merged the changes in this PR. It is required for the fixing of this PR.

@JayjeetAtGithub JayjeetAtGithub mentioned this pull request Jun 26, 2021
Closed
@JayjeetAtGithub JayjeetAtGithub marked this pull request as ready for review June 26, 2021 08:25
This was referenced Jun 26, 2021
Closed
Closed
@lgray lgray merged commit efecd87 into CoffeaTeam:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshadura oshadura oshadura left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JayjeetAtGithub @lgray @oshadura