Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow lookup_base args to be in any order #811

Merged
merged 1 commit into from May 13, 2023

Conversation

lgray
Copy link
Collaborator

@lgray lgray commented May 13, 2023

also: use proper client context on workers when using latest dask

Fixes #810.

Turns out bind was just the idea of what I wanted to do rather than the implementation @agoose77.
Probably means I want to re-engineer lookup_base at some point to be less strange.

@lgray
Copy link
Collaborator Author

lgray commented May 13, 2023

@martindurant This is what I would like to replace, since it's a workaround for repeated deserialization of possibly very heavy correction functions. If I could instead encode the necessary metadata in a way that doesn't get deserialized every partition the correction/lookup data everything would be significantly cleaner!

Finding a more pleasant solution to this would also help out #798.

@lgray lgray merged commit fb651ab into master May 13, 2023
12 of 14 checks passed
@lgray lgray deleted the allow_arbitrary_order_lookup_base branch June 26, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use inspect.bind in lookup_base
1 participant