Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new dask methods #926

Merged
merged 10 commits into from
Nov 30, 2023

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 force-pushed the agoose77/refactor-use-dask-method branch from 9a480aa to 912d006 Compare November 13, 2023 17:36
@lgray
Copy link
Collaborator

lgray commented Nov 21, 2023

@agoose77 this is in the right direction but there's one big problem in that now iterated __getattr__ seems to not be supported:

repro:

from coffea.nanoevents import NanoEventsFactory
events = NanoEventsFactory.from_root(
    "tests/samples/nano_dy.root:Events",
).events()

events.Jet.matched_muons.matched_jet

now fails with:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'function' object has no attribute 'matched_jet'

@lgray
Copy link
Collaborator

lgray commented Nov 22, 2023

@agoose77

Still running into some regressions:

pytest tests/test_nanoevents_pfnano.py tests/test_nanoevents_physlite.py

results in a couple failed tests with:

TypeError: meta must be an instance of an Awkward Array, not <class 'dask_awkward.lib.core.Array'>.

and

NotImplementedError: 

Which were not encountered before!

@lgray
Copy link
Collaborator

lgray commented Nov 27, 2023

@agoose77 ok this last edit gets rid of all the regressions on my side.

@agoose77
Copy link
Contributor Author

OK, let's look to merging this in dask-awkward, then :)

@lgray
Copy link
Collaborator

lgray commented Nov 27, 2023

@agoose77 is there any way we can make it so I don't have to repeat functions like metadata that access awkward-array information but don't need dask? That seems rather pesky.

@agoose77
Copy link
Contributor Author

@lgray sure! Let me think about it.

@agoose77
Copy link
Contributor Author

@lgray try this (with new dask-awkward in my branch)

@lgray
Copy link
Collaborator

lgray commented Nov 28, 2023

all green in local tests.

@lgray
Copy link
Collaborator

lgray commented Nov 29, 2023

Once all that gets merged I'll finally switch nanoevents to use transient attrs and can get rid of that nasty copyreg I use right now. Woo.

@lgray lgray marked this pull request as ready for review November 30, 2023 15:19
@lgray lgray enabled auto-merge November 30, 2023 15:37
@lgray lgray merged commit be3d18a into CoffeaTeam:master Nov 30, 2023
6 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants