Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove all eager len calls #928

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

ikrommyd
Copy link
Contributor

This PR aims to remove all eager len calls from coffea to adapt to the changes proposed in dask-contrib/dask-awkward#416

@ikrommyd
Copy link
Contributor Author

analysis_tools tests are passing locally now that dask-contrib/dask-awkward#417 is merged

@ikrommyd
Copy link
Contributor Author

@lgray I've searched the coffea src code and all len calls look fine to me. I'm not 100% sure about some in nanoevents and in the lookup tools. Please control-F it to cross-check if you have a little bit of time. Tests should be passing once dask-contrib/dask-awkward#417 is into a pypi release as they are passing locally. I'm not checking these though:

SKIPPED [2] tests/processor/servicex/__init__.py:30: could not import 'servicex': No module named 'servicex'
SKIPPED [1] tests/test_ml_tools.py:75: could not import 'tritonclient': No module named 'tritonclient'
SKIPPED [1] tests/test_ml_tools.py:122: could not import 'torch': No module named 'torch'
SKIPPED [1] tests/test_ml_tools.py:160: could not import 'xgboost': No module named 'xgboost'
SKIPPED [1] tests/test_parsl.py:10: could not import 'parsl': No module named 'parsl'
SKIPPED [1] tests/test_parsl.py:39: could not import 'parsl': No module named 'parsl'
SKIPPED [1] tests/test_parsl.py:126: could not import 'parsl': No module named 'parsl'
SKIPPED [1] tests/test_parsl.py:134: could not import 'parsl': No module named 'parsl'
SKIPPED [1] tests/test_spark.py:5: could not import 'pyspark': No module named 'pyspark'
SKIPPED [1] tests/test_spark.py:13: pyspark executor work currently in progress
SKIPPED [1] tests/test_spark.py:109: could not import 'pyspark': No module named 'pyspark'

@lgray lgray merged commit d5b190a into CoffeaTeam:master Nov 17, 2023
14 checks passed
@ikrommyd ikrommyd deleted the fix-remove-eager-len-calls branch November 17, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants