Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improvements to dataset_query tools #940

Merged

Conversation

valsdav
Copy link
Contributor

@valsdav valsdav commented Nov 28, 2023

  • Fixed allowlist/blocklist naming
  • More general scope (not only cms hardcoded paths)
  • Read rucio config from file
  • select and query replicates with an "all" option in the cli
  • Read datasets definition from file
  • Call preprocessing macro from the cli
  • Move away from cmd2 and just use rich.Prompt
  • docs:
    • notebook

@lgray
Copy link
Collaborator

lgray commented Nov 28, 2023

@valsdav ping me when you're done and I'll merge to the main PR!

@valsdav
Copy link
Contributor Author

valsdav commented Dec 8, 2023

Moving now the implementation of the cli to pure rich to remove cmd2 dependency and reuse the functions for "dataset config" loading.

@lgray lgray marked this pull request as ready for review December 12, 2023 10:57
@lgray lgray merged commit 2457e08 into CoffeaTeam:local_executors_to_dask Dec 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants