Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and version constraints #3

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Update dependencies and version constraints #3

merged 1 commit into from
Nov 8, 2020

Conversation

christiaan
Copy link
Contributor

Loosened the constraint for php-translation/symfony-bundle as the caret version range handles 0.x.x specially.

@emri99
Copy link
Member

emri99 commented Oct 30, 2020

First, Thanks for your contribution ;)

I understand your meaning about caret version range, however removing PHP 5.6, 7.0, 7.1 versions is a bit more problematic for our usage as we need to keep compatibility for our legacy projects using theses versions.

What was the reason for removing PHP < 7.2 ?
Did you experiment problems when just changing caret version ? (I haven't test it yet)

@christiaan
Copy link
Contributor Author

What was the reason for removing PHP < 7.2 ?
Did you experiment problems when just changing caret version ? (I haven't test it yet)

Mainly because the dependencies of this package also dropped support. Trying to keep < 7.2 supported would mean that newer dependencies are not supported.

Supporting 7.2 is even quite liberal seeing as support for 7.2 is due to expire 30 nov.

php-translation/extractor requires minimal version 7.2,
php-translation/symfony-bundle requires minimal 7.1

What about releasing this change as a new Major version? The current version works fine for older versions of packages that also support <7.2.

@emri99
Copy link
Member

emri99 commented Nov 4, 2020

I'll do my best to valid your PR and release a new major version this week-end ;)

@emri99 emri99 merged commit bde518a into Coffreo:master Nov 8, 2020
@emri99
Copy link
Member

emri99 commented Nov 8, 2020

I release v2 version to keep v1 for stable version on PHP < 7.2.
Thanks again ;)

@christiaan
Copy link
Contributor Author

Thank you for creating this and still maintaining it! 👍

@christiaan christiaan deleted the master_update-dependencies branch November 9, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants