Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3 Mod] Tempban doesn't remove the user from settings on unban #2160

Closed
Zephyrkul opened this issue Sep 30, 2018 · 2 comments · Fixed by #2161
Closed

[V3 Mod] Tempban doesn't remove the user from settings on unban #2160

Zephyrkul opened this issue Sep 30, 2018 · 2 comments · Fixed by #2161
Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Comments

@Zephyrkul
Copy link
Contributor

Command bugs

Command name

tempban

What cog is this command from?

Mod

What were you expecting to happen?

When the user is unbanned and then permanently banned, they remain permanently banned.

What actually happened?

The user is unbanned by the bot on the next loop due to their previous tempban having expired.

How can we reproduce this issue?

  1. Tempban a user.
  2. User is unbanned and rejoins.
  3. User is permanently banned. Another tempban overrides the settings, so an extended tempban sidesteps the issue.
  4. User is unbanned by the bot when the unban task loop runs again.
@Zephyrkul Zephyrkul mentioned this issue Sep 30, 2018
Merged
1 task
@Tobotimus Tobotimus added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. V3 Status: In Progress There's a PR open to deal with this, or an org member is working on this internally labels Sep 30, 2018
@netflixandbill
Copy link

I can try to find the logs or other debug info from when this was happening to give some more insight on this. thanks for writing this up too.

Tobotimus pushed a commit that referenced this issue Oct 1, 2018
@Zephyrkul @Tobotimus
[Mod] Remove tempban from data after unbanning (#2161)
a9b328f 
Resolves #2160.

Also resolves another issue where the bot will error out when getting the guild's invites when it doesn't have the Manage Server permission.
@Tobotimus
Copy link
Member

@netflixandbill Thanks for offering but there's no need, this issue is resolved by #2161 😃

@Tobotimus Tobotimus removed the Status: In Progress There's a PR open to deal with this, or an org member is working on this internally label Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[V3 Mod] Remove tempban from data after unbanning
3 participants
@Tobotimus @Zephyrkul @netflixandbill