Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Customcom] Fix error on exiting customcom interactive menu. #3417

Merged
merged 4 commits into from
Jan 19, 2020
Merged

[Customcom] Fix error on exiting customcom interactive menu. #3417

merged 4 commits into from
Jan 19, 2020

Conversation

Stonedestroyer
Copy link
Contributor

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Resolves #3416

@Jackenmen Jackenmen self-assigned this Jan 19, 2020
@Jackenmen Jackenmen added Category: Cogs - CustomCommands This is related to the CustomCommands cog. Type: Fix labels Jan 19, 2020
Jackenmen
Jackenmen requested changes Jan 19, 2020
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change works fine, just one suggestion I think should be applied here.

redbot/cogs/customcom/customcom.py Outdated Show resolved Hide resolved
@Jackenmen Jackenmen added this to the Next Feature Release milestone Jan 19, 2020
@Jackenmen Jackenmen self-requested a review January 19, 2020 17:05
@Jackenmen Jackenmen changed the title [Customcom] Fixes error on exit [Customcom] Fix error on exiting customcom interactive menu. Jan 19, 2020
@Jackenmen Jackenmen merged commit 7f390df into Cog-Creators:V3/develop Jan 19, 2020
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palmtree5 palmtree5 Awaiting requested review from palmtree5

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

@Jackenmen Jackenmen Awaiting requested review from Jackenmen

Assignees

@Jackenmen Jackenmen

Labels
Category: Cogs - CustomCommands This is related to the CustomCommands cog. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Custom Command create random error
2 participants
@Stonedestroyer @Jackenmen