Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitch Streamalert links to localized names #3772

Closed
naitoshedo opened this issue Apr 20, 2020 · 1 comment · Fixed by #3773
Closed

Twitch Streamalert links to localized names #3772

naitoshedo opened this issue Apr 20, 2020 · 1 comment · Fixed by #3773
Labels
Category: Cogs - Streams This is related to the Streams cog. Status: Accepted We want this Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.

Comments

@naitoshedo
Copy link

Command name

[p]twitchalert twitch

What cog is this command from?

streams

What were you expecting to happen?

Broadcast message should link to twitch URL not twitch localized name URL.

What actually happened?

Stream alert links to Twitch user's localized name instead of their twitch URL resulting in a 404.

How can we reproduce this issue?

[p]streamalert twitch hinamakura

Alert will link to https://www.twitch.tv/%E3%81%B2%E3%81%AA%E3%81%BE%E3%81%8F%E3%82%89

instead of
https://www.twitch.tv/hinamakura
@naitoshedo naitoshedo added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Apr 20, 2020
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Apr 20, 2020
@Kowlin
Copy link
Member

Kowlin commented Apr 20, 2020

Ahh the joys of i18n never ceases to amaze me.

@Kowlin Kowlin added Status: Accepted We want this and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Apr 20, 2020
@Jackenmen Jackenmen added the Category: Cogs - Streams This is related to the Streams cog. label Apr 20, 2020
@Jackenmen Jackenmen mentioned this issue Apr 20, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Cogs - Streams This is related to the Streams cog. Status: Accepted We want this Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using localised display name in stream url Jackenmen/Red-DiscordBot
3 participants
@naitoshedo @Jackenmen @Kowlin