[Streams] Only send message about missing client secret once #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… last notify_owner
Jackenmen
added
Category: Cogs - Streams
Jackenmen
previously approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Works great, I only wonder if notified_owner is the best name here - there could be more situations where we would want to notify owner in future and it could be confusing if there were notified_owner but also notified_owner_about_something.
I'm approving this anyway, but if you want to change that name, feel free to.
There's also one string suggestion but it's not related to the actual change so it can be ignored too.
|
wait no, dont merge i agree with you, and to avoid a migration later lets do it now |
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Jackenmen
changed the title
Cog-CreatorsBot
added
the
Changelog Entry: Pending
Jackenmen
added
Changelog Entry: Added
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Type
Description of the changes
fixes #3587