Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reset the accounts when changing bank's global status #4068

Open
1 of 3 tasks
flaree opened this issue Jul 10, 2020 · 10 comments
Open
1 of 3 tasks

Don't reset the accounts when changing bank's global status #4068

flaree opened this issue Jul 10, 2020 · 10 comments
Labels
Category: Core - API - Bank This is related to the core Bank API. Status: Needs Discussion Needs more discussion. Type: Feature New feature or request.

Comments

@flaree
Copy link
Member

flaree commented Jul 10, 2020

Feature request

Select the type of feature you are requesting:

  • Cog
  • Command
  • API functionality

Describe your requested feature

I feel that the wiping of economy when switching has no real impact. I'd like to be able to go back should I not like it and resume from where the leaderboard was at at the time I switched

@flaree flaree added the Type: Feature New feature or request. label Jul 10, 2020
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Jul 10, 2020
@Drapersniper
Copy link
Contributor

Im in favour of this however...

I can see 2 problems here.

1 - storage size (with recent improvements to json driver this is less of an issue)
2 - Would it be confusing to the user if their currency is reset to what it was on last change?
say they has 1M in global and 50k in Server, then you toggle from global to server their balance will go from 1M to 50k (or 0 in most cases) without any sort of information to the user I think that could be confusing.

@flaree
Copy link
Member Author

flaree commented Jul 10, 2020

I mean its kinda confusing to users right now, they look and see a server balance of X then the owner decides to go global and boom everything's now 0.

@Drapersniper
Copy link
Contributor

touche, guess that your suggestion here doesnt make anything any worse.
I've upvote this proposal, there no valid reason I currently see for wiping the bank on a type change.

@Drapersniper Drapersniper added Category: Core - API - Bank This is related to the core Bank API. Status: Needs Discussion Needs more discussion. and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Jul 10, 2020
@Jackenmen Jackenmen changed the title Resetting the economy when switching between guild and global Don't reset the accounts when changing bank's global status Jul 10, 2020
@Jackenmen
Copy link
Member

I don't really agree with this, I think it's gonna be more confusing if the accounts go back to whatever they had in the other state after you switch bank's global status. IMO, you shouldn't carelessly be switching the global status of the bank in the first place.

@flaree
Copy link
Member Author

flaree commented Jul 10, 2020

I feel they should be allowed to switch between without losing data. When I first started using Red I liked to play around with stuff and find out what preferences I liked. To do that I needed to experiment and the losing of the data is a bad way to do it. Atleast having the user choose to clear it will be a better way.

@Drapersniper
Copy link
Contributor

As a bot owner I did have instances where I wanted the currency changed without wiping it though. So just advocating for that.

@Drapersniper
Copy link
Contributor

We could just add a keyword that option that resets without wiping. And keep the current behaviour the same.

@yamikaitou
Copy link
Contributor

My opinion would be to combine the accounts if switching from Guild to Global. But if you switch from Global to Guild, reset it.

@Drapersniper
Copy link
Contributor

i erm i dont likee the idea of combining ...
some servers could have a completely out of wack currency prior to conversion.

@yamikaitou
Copy link
Contributor

True, didn't consider that. Then I agree with the optional flag/command to either keep or wipe it (I'd say default to wipe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core - API - Bank This is related to the core Bank API. Status: Needs Discussion Needs more discussion. Type: Feature New feature or request.
Projects
None yet
Development

No branches or pull requests

4 participants