Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Filter Cog Guide #4579

Merged
merged 16 commits into from Jan 16, 2021
Merged

[Docs] Filter Cog Guide #4579

merged 16 commits into from Jan 16, 2021

Conversation

bobloy
Copy link
Contributor

@bobloy bobloy commented Nov 5, 2020

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

User guide for the Filter cog. Docs were automatically generated using the same method as #4488
A step towards the #1734 goal

@Flame442 Flame442 added Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Type: Enhancement Something meant to enhance existing Red features. Category: Cogs - Filter This is related to the Filter cog. labels Nov 7, 2020
@bobloy bobloy marked this pull request as ready for review November 12, 2020 21:24
@bobloy
Copy link
Contributor Author

bobloy commented Nov 12, 2020

This is now ready for review. If #4599 is accepted, will fix [words...] to <words...>

@Flame442 Flame442 self-assigned this Dec 30, 2020
Flame442
Flame442 requested changes Jan 13, 2021
View reviewed changes
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor consistency and grammar issues, but otherwise solid. Thanks for contributing.

docs/cog_guides/filter.rst Outdated Show resolved Hide resolved
docs/cog_guides/filter.rst Outdated Show resolved Hide resolved
docs/cog_guides/filter.rst Outdated Show resolved Hide resolved
redbot/cogs/filter/filter.py Outdated Show resolved Hide resolved
redbot/cogs/filter/filter.py Outdated Show resolved Hide resolved
redbot/cogs/filter/filter.py Outdated Show resolved Hide resolved
@Flame442 Flame442 added the QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. label Jan 13, 2021
bobloy and others added 6 commits January 14, 2021 08:17
@bobloy @Flame442
Update redbot/cogs/filter/filter.py
6bbad82 
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
@bobloy @Flame442
Update redbot/cogs/filter/filter.py
e1d7bae 
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
@bobloy @Flame442
Update redbot/cogs/filter/filter.py
6a5c45f 
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
@bobloy @Flame442
Update docs/cog_guides/filter.rst
7f015a0 
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
@bobloy @Flame442
Update docs/cog_guides/filter.rst
c4b9f15 
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
@bobloy @Flame442
Update docs/cog_guides/filter.rst
e7b97a4 
Co-authored-by: Flame442 <34169552+Flame442@users.noreply.github.com>
Flame442
Flame442 previously approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once the merge conflict is resolved!

@Flame442 Flame442 added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. labels Jan 16, 2021
@Flame442 Flame442 added this to the 3.4.6 milestone Jan 16, 2021
Flame442
Flame442 approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

@Flame442 Flame442 enabled auto-merge (squash) January 16, 2021 02:10
@Flame442 Flame442 merged commit 8d512e2 into Cog-Creators:V3/develop Jan 16, 2021
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Jan 16, 2021
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Jan 20, 2021
@bobloy bobloy deleted the cog_guide_filter branch January 26, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flame442 Flame442 Flame442 approved these changes

Assignees

@Flame442 Flame442

Labels
Category: Cogs - Filter This is related to the Filter cog. Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Milestone
3.4.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bobloy @Flame442 @Jackenmen @Cog-CreatorsBot