Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Cleanup Cog Guide #4488

Merged
merged 9 commits into from Oct 28, 2020
Merged

[Docs] Cleanup Cog Guide #4488

merged 9 commits into from Oct 28, 2020

Conversation

bobloy
Copy link
Contributor

@bobloy bobloy commented Oct 14, 2020 •
edited

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Adds the cleanup cog guide to the docs. Based on the descriptions provided in the commands.
Personalization may be necessary, feedback on that would be helpful.

@bobloy bobloy marked this pull request as ready for review October 14, 2020 17:52
@bobloy
Copy link
Contributor Author

bobloy commented Oct 14, 2020

The strategy I took was generating the docs based on the cog, so this PR also includes updates to the cleanup cog.
If this strategy is approved, I'll add PRs for the remaining cogs.

@bobloy bobloy mentioned this pull request Oct 14, 2020
Merged
3 tasks
@bobloy
Copy link
Contributor Author

bobloy commented Oct 19, 2020

Found the related issue: #1734

@bobloy bobloy mentioned this pull request Oct 19, 2020
Merged
3 tasks
@Drapersniper Drapersniper added Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Category: Cogs - Cleanup This is related to the Cleanup cog. hacktoberfest-accepted labels Oct 21, 2020
@Drapersniper Drapersniper added this to the 3.4.2 milestone Oct 22, 2020
@bobloy bobloy mentioned this pull request Oct 22, 2020
Merged
3 tasks
@Drapersniper Drapersniper added the Type: Enhancement Something meant to enhance existing Red features. label Oct 23, 2020
@Flame442 Flame442 self-assigned this Oct 26, 2020
Flame442
Flame442 requested changes Oct 26, 2020
View reviewed changes
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor grammar fix I would like to get handled before it spreads

docs/cog_guides/cleanup.rst Outdated Show resolved Hide resolved
@Flame442 Flame442 added the QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. label Oct 26, 2020
Flame442
Flame442 approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Flame442 Flame442 added QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). and removed QA: Changes Requested Used by few QA members. Awaiting changes requested by maintainers or QA. labels Oct 28, 2020
@Flame442 Flame442 merged commit 252951c into Cog-Creators:V3/develop Oct 28, 2020
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Oct 28, 2020
@bobloy bobloy deleted the cog_guide_cleanup branch October 28, 2020 15:26
@Jackenmen Jackenmen removed the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Oct 28, 2020
@Jackenmen Jackenmen added the Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. label Oct 28, 2020
@Jackenmen Jackenmen modified the milestones: 3.4.3, 3.4.2 Oct 28, 2020
@bobloy bobloy mentioned this pull request Nov 5, 2020
Merged
3 tasks
@Jackenmen Jackenmen added this to Done in User guides Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flame442 Flame442 Flame442 approved these changes

Assignees

@Flame442 Flame442

Labels
Category: Cogs - Cleanup This is related to the Cleanup cog. Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Enhancement Something meant to enhance existing Red features.
Projects
User guides
  
Done
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bobloy @Flame442 @Jackenmen @Drapersniper @Cog-CreatorsBot