Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command usage of [p]choose command #4733

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Fix command usage of [p]choose command #4733

merged 2 commits into from
Jan 23, 2021

Conversation

Jackenmen
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Few got missed in my last PR (#4589).

Found with:

for com in bot.walk_commands():
    if com.signature.endswith("...]"):
        print(com.qualified_name, com.signature)

@Jackenmen Jackenmen added this to the 3.4.6 milestone Jan 13, 2021
@github-actions github-actions bot added Category: Cogs - Filter This is related to the Filter cog. Category: Cogs - General This is related to the General cog. labels Jan 13, 2021
@Flame442 Flame442 self-assigned this Jan 18, 2021
@Jackenmen Jackenmen added the Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. label Jan 20, 2021
@github-actions github-actions bot removed the Category: Cogs - Filter This is related to the Filter cog. label Jan 20, 2021
@Jackenmen Jackenmen changed the title Fix usage in more commands with variadic required arguments Fix command usage of [p]choose command Jan 20, 2021
@Jackenmen
Copy link
Member Author

It turns out that most of this PR was already done before in #4599 so I've reverted those changes and this is now +1 -1 PR.

Flame442
Flame442 approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@Flame442 Flame442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1-1 from me!

@Flame442 Flame442 added the QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). label Jan 23, 2021
@Flame442 Flame442 merged commit 2ce4a27 into Cog-Creators:V3/develop Jan 23, 2021
@Jackenmen Jackenmen deleted the V3/more_wrong_usage branch February 16, 2021 22:39
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flame442 Flame442 Flame442 approved these changes

Assignees

@Flame442 Flame442

Labels
Category: Cogs - General This is related to the General cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@Jackenmen @Flame442