Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use brew install --cask instead of brew cask install #4865

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Use brew install --cask instead of brew cask install #4865

merged 1 commit into from
Mar 1, 2021

Conversation

Jackenmen
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

brew cask install has been removed in Brew 3.0.0: Homebrew/brew#10397

You can see the error when running our current install instructions here:
https://github.com/jack1142/Red-Install-Tests/runs/1998480687?check_suite_focus=true

@aikaterna because this affects Mac, I would appreciate it if you could verify this works

@Jackenmen Jackenmen added Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Type: Fix labels Feb 28, 2021
@Jackenmen Jackenmen added this to the 3.4.8 milestone Feb 28, 2021
aikaterna
aikaterna approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@aikaterna aikaterna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any user with an old Homebrew install will be forced into using the updated syntax as the program automatically updates when any Homebrew command is run, so that's good.

@aikaterna aikaterna merged commit 85dc6f4 into Cog-Creators:V3/develop Mar 1, 2021
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Mar 1, 2021
@Jackenmen Jackenmen deleted the V3/install_docs_fixes branch March 1, 2021 17:26
@Jackenmen Jackenmen modified the milestones: 3.4.9, 3.4.8 Apr 1, 2021
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Apr 5, 2021
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aikaterna aikaterna aikaterna approved these changes

Assignees

@aikaterna aikaterna

Labels
Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Jackenmen @aikaterna @Cog-CreatorsBot