Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Timeout value for "dc" setting #5350

Open
walliski opened this issue Sep 29, 2021 · 4 comments · May be fixed by #5921
Open

[Audio] Timeout value for "dc" setting #5350

walliski opened this issue Sep 29, 2021 · 4 comments · May be fixed by #5921
Labels
Category: Cogs - Audio This is related to the Audio cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Enhancement Something meant to enhance existing Red features.

Comments

@walliski
Copy link

What component of Red (cog, command, API) would you like to see improvements on?

Audio

Describe the enhancement you're suggesting.

Currently it seems like the alternatives are that the bot either stays in the channel until its empty, and then disconnects after a emptydisconnect time, or it disconnects immediately after the queue goes empty, with the dc setting.

I think it would make a lot of sense if you could configure a timeout for the dc setting, in the form of "Wait X amount of seconds before disconnecting on empty queue". This would allow you to have the bot disconnect when its done playing, but at the same time also reduce the amount of unnecessary disconnects. I often see new songs being queued directly after the current one is done, and the bot has just 1 second ago disconnected.

Anything else?

No response

@walliski walliski added the Type: Enhancement Something meant to enhance existing Red features. label Sep 29, 2021
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Sep 29, 2021
@Flame442 Flame442 added the Category: Cogs - Audio This is related to the Audio cog. label Dec 9, 2021
@Flame442 Flame442 added Status: PRs Welcome No one is currently assigned to this issue, but we'd be grateful if anyone made a PR. and removed Status: Needs Triage This has not been labeled or discussed for handling yet. labels Sep 15, 2022
@AntonioNarra
Copy link
Contributor

Hi @walliski @Flame442. I'm interested in working on this. I'd like to add a parameter that specifies how long before disconnecting (in seconds) on an empty queue with the dc setting enabled as @walliski suggests.

@Flame442
Copy link
Member

Flame442 commented Nov 7, 2022

As the label suggests, PRs are welcome for this issue. Feel free to make one in accordance with our CONTRIBUTING.MD file. If you need any additional help, feel free to ask on the Redbot discord server.

@AntonioNarra
Copy link
Contributor

Sounds good! May I be assigned to this in that case?

@Flame442
Copy link
Member

Flame442 commented Nov 7, 2022

Assignment on issues really doesn't mean anything, but if it makes you feel better sure.

@AntonioNarra AntonioNarra linked a pull request Dec 2, 2022 that will close this issue
@Flame442 Flame442 added Status: In Progress There's a PR open to deal with this, or an org member is working on this internally and removed Status: PRs Welcome No one is currently assigned to this issue, but we'd be grateful if anyone made a PR. labels Dec 2, 2022
@AntonioNarra AntonioNarra removed their assignment Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog. Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants