Fix descriptions for examples of ID-based command invocations in Mod #5372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackenmen
requested changes
Oct 4, 2021
Jackenmen
added
Type: Bug
Kreusada
requested changes
Oct 4, 2021
github-actions
bot
added
the
Category: Docs - Other
Jackenmen
changed the title
Jackenmen
changed the title
Jackenmen
changed the title
|
Thanks WreckRox for the PR 🎉. I'm working now to backport this PR to: 3.4. |
red-githubbot
bot
added
the
Changelog Entry: Pending
Red-GitHubBot
pushed a commit
to Red-GitHubBot/Red-DiscordBot
that referenced
this pull request
Oct 15, 2021
…n Mod (Cog-Creators#5372) * Fix wording in redbot/cogs/mod/kickban.py to match with the command example * Made changes as requested in PR Review #770078179 * Added changes to docs/cog_guides/mod.rst as requested in PR Review #70784066 * Fixed kick wording * Fix kick wording (cherry picked from commit 9aee8ce) Co-authored-by: WreckRox <24494367+WreckRox@users.noreply.github.com>
Jackenmen
pushed a commit
that referenced
this pull request
Oct 15, 2021
…n Mod (#5372) (#5399) * Fix wording in redbot/cogs/mod/kickban.py to match with the command example * Made changes as requested in PR Review #770078179 * Added changes to docs/cog_guides/mod.rst as requested in PR Review #70784066 * Fixed kick wording * Fix kick wording (cherry picked from commit 9aee8ce) Co-authored-by: WreckRox <24494367+WreckRox@users.noreply.github.com> Co-authored-by: WreckRox <24494367+WreckRox@users.noreply.github.com>
Jackenmen
added
Changelog Entry: Added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
The example command in kickban.py#L385 stated
[p]ban 428675506947227648 7 Continued to spam after told to stop. This will ban Twentysix and it will delete 7 days worth of messages.The description is inconsistent with the example command. Changed the example command description to
This will ban the User ID 428675506947227648 and it will delete 7 days worth of messages.