Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bordered() utility function #5692

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Remove bordered() utility function #5692

merged 1 commit into from
Nov 11, 2022

Conversation

Jackenmen
Copy link
Member

Description of the changes

This has probably never been used outside of Core which makes it a perfect candidate for private namespace but, since we also no longer use it, we can just drop this code entirely.

Have the changes in this PR been tested?

Yes

@Jackenmen Jackenmen added Breaking Change Will potentially break some cogs. Type: Removal This intends to remove some functionality. labels May 6, 2022
@Jackenmen Jackenmen added this to the 3.5.0 milestone May 6, 2022
@github-actions github-actions bot added Category: Bot Core Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` labels May 6, 2022
Kowlin
Kowlin approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@Kowlin Kowlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, that's an relic from the past before we transitioned to Rich for the CLI.

@Jackenmen
Copy link
Member Author

Jackenmen commented May 6, 2022 •
edited
Loading

Seems like "this has probably never been used outside of Core" is technically wrong however, I don't think that should really stop us as it doesn't really fit into chat formatting utils...

https://github.com/Kreusada/Kreusada-Cogs/blob/b1e66746ed39d208a6f157419cc1a05a48769119/captcha/commands/settings.py#L195

(don't let the forms fool you, it's chat_formatting)

@Jackenmen Jackenmen merged commit 51fa3f5 into Cog-Creators:V3/develop Nov 11, 2022
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Nov 11, 2022
@Jackenmen Jackenmen deleted the remove_bordered_util_function branch November 11, 2022 14:37
Drapersniper pushed a commit to Drapersniper/Red-DiscordBot that referenced this pull request Nov 27, 2022
@Jackenmen @Drapersniper
Remove bordered() utility function (Cog-Creators#5692)
2a19035
Drapersniper pushed a commit to Drapersniper/Red-DiscordBot that referenced this pull request Dec 2, 2022
@Jackenmen @Drapersniper
Remove bordered() utility function (Cog-Creators#5692)
b6318a7
Jackenmen added a commit to Jackenmen/Red-DiscordBot that referenced this pull request Dec 31, 2022
@Jackenmen
Remove bordered() utility function (Cog-Creators#5692)
fc44787
@Flame442 Flame442 added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Apr 30, 2023
@github-actions github-actions bot removed the Category: Docs - Other This is related to documentation that doesn't have its dedicated label. label Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kowlin Kowlin Kowlin approved these changes

Assignees
No one assigned
Labels
Breaking Change Will potentially break some cogs. Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Removal This intends to remove some functionality.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Jackenmen @Kowlin @Flame442