Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Audio] Add Lavalink Jar build to settings #1430

Merged
merged 9 commits into from
Apr 17, 2018
Merged

[V3 Audio] Add Lavalink Jar build to settings #1430

merged 9 commits into from
Apr 17, 2018

Conversation

TheWyn
Copy link
Contributor

@TheWyn TheWyn commented Mar 14, 2018

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Added Lavalink Jar build to Lavalink settings since build number now stored in config.

Added Lavalink Jar build to Lavalink settings since build number now stored in config.
@tekulvw
Copy link
Member

tekulvw commented Mar 14, 2018

I'm hesitant to merge this now because of the impending audio overhaul. We may just opt to integrate these changes into that PR.

@Kowlin
Copy link
Member

Kowlin commented Mar 16, 2018

I agree with that Will. I think its better to wait for the overall PR.

@Kowlin
Copy link
Member

Kowlin commented Mar 20, 2018

PR has Merge conflict after merging #1440, please resolve this.

@tekulvw
Copy link
Member

tekulvw commented Mar 20, 2018

New lib doesn't have a __version__ yet, will need to add that first.

@TheWyn
Copy link
Contributor Author

TheWyn commented Apr 17, 2018

Done @Kowlin

@palmtree5 palmtree5 merged commit 6d714db into Cog-Creators:V3/develop Apr 17, 2018
@TheWyn TheWyn deleted the patch-1 branch May 10, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants