[V3 Instance setup] implement backup support for instances using Mongo #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palmtree5
changed the title
tekulvw
suggested changes
Mar 28, 2018
redbot/setup.py
Outdated
| @@ -16,6 +16,8 @@ | |||
| from redbot.core.data_manager import basic_config_default | |||
| from redbot.core.json_io import JsonIO | |||
| from redbot.core.utils import safe_delete | |||
| from redbot.core.drivers.red_mongo import Mongo, get_config_details | |||
There was a problem hiding this comment.
You can't import these here as the bot will fail if the user doesn't have motor installed. Both of these imports should be in the X_to_Y functions.
tekulvw
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Implement backup support for MongoDB instances. Previously not implemented but as a result of my working on storage backend switching, I now know what I needed to do to export to JSON for backup purposes.