[V3 Economy] Add per-role payouts to Economy with [p]economyset rolepaydayamount #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmendez
changed the title
skmendez
changed the title
skmendez
changed the title
|
Why is this limited to global? |
|
@tekulvw it's not lol. Role-based payday payouts are restricted to the bank NOT being global |
palmtree5
reviewed
Apr 3, 2018
| @@ -255,7 +260,12 @@ def __init__(self, bot: Red): | |||
| else: | |||
| next_payday = await self.config.member(author).next_payday() | |||
| if cur_time >= next_payday: | |||
| await bank.deposit_credits(author, await self.config.guild(guild).PAYDAY_CREDITS()) | |||
| credit_amount = await self.config.guild(guild).PAYDAY_CREDITS() | |||
| for role in author.roles: | |||
There was a problem hiding this comment.
why iterate through all of a user's roles to find a payday amount rather than just getting the payday amount based on the user's top role?
There was a problem hiding this comment.
All roles don't necessarily have a corresponding pay-out, so while their top role might be Admin, their highest pay-out role might be Gold/Platinum or the like.
palmtree5
approved these changes
Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
This is only possible if the bank isn't global. When
paydayis ran, the maximum of all of the payouts (default of 0 for every role) for the roles the Member has and the default guild payout is paid to the user.