Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3 Core] fix some issues with [p]set and [p]set nickname #1494

Merged
merged 3 commits into from
Apr 4, 2018
Merged

[V3 Core] fix some issues with [p]set and [p]set nickname #1494

merged 3 commits into from
Apr 4, 2018

Conversation

palmtree5
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes #1493

Fixes an AttributeError with [p]set when mod and/or admin roles are not set

Also makes [p]set nickname actually usable

@palmtree5 palmtree5 requested a review from tekulvw as a code owner April 3, 2018 05:35
@palmtree5 palmtree5 added the V3 label Apr 3, 2018
@palmtree5
Copy link
Member Author

I've tested all of the changes here and they're working as intended

@Kowlin Kowlin merged commit 402f6c1 into Cog-Creators:V3/develop Apr 4, 2018
@Kowlin Kowlin mentioned this pull request Apr 4, 2018
Closed
2 tasks
@tekulvw tekulvw mentioned this pull request Apr 5, 2018
Closed
@palmtree5 palmtree5 deleted the V3/bugfix/1493 branch May 31, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekulvw tekulvw tekulvw approved these changes

@Kowlin Kowlin Kowlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[V3 Core] Set nickname not changing
3 participants
@palmtree5 @tekulvw @Kowlin