[V3 Mod] Denying add_reactions permission to muted users #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palmtree5
requested changes
Apr 16, 2018
redbot/cogs/mod/mod.py
Outdated
| @@ -886,6 +886,7 @@ def __unload(self): | |||
|
|
|||
| perms_cache[str(channel.id)] = overwrites.send_messages | |||
There was a problem hiding this comment.
Let's actually make this track both the original setting of the send_messages overwrite and the add_reactions overwrite so that we can just set it back to the old value on unmute
palmtree5
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Since some of my members like spamming reactions when they get muted, I think that's a good idea to deny them the permission of adding reactions.