Remove old usage of type tuples with config. #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to get multiple confirmations that this PR does not effect existing data. I don't believe it will, but we need to be pretty damn certain. |
|
My V3 instance isnt handling modlog on any of my servers yet, so I cant test for that. I can test the bank change included though. I also already verified that dataconverter works as expected after these changes. |
tekulvw
approved these changes
Apr 17, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dataconverter to work with that.
Type
Description of the changes
Also resolves the weirdness with #1511 (which was only occurring due to the old type tuple syntax)