Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] guild->server (And customcom recognizes {server} ) #1529

Merged
merged 1 commit into from
Apr 16, 2018
Merged

[V3] guild->server (And customcom recognizes {server} ) #1529

merged 1 commit into from
Apr 16, 2018

Conversation

bobloy
Copy link
Contributor

@bobloy bobloy commented Apr 16, 2018

Update redbot/cogs/ to guild vs. server best practice
Mostly string renames
customcom now recognized {guild} and {server}

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Mostly user-facing text fixes of guild -> server
Allows {server} to be recognized by custom commands

Mostly string renames
customcom now recognized {guild} and {server}
@shikhir-arora
Copy link

V3 uses Discord.py rewrite, so I think the goal here is to be consistent. From the docs for the rewrite:

The official API documentation calls the “Server” concept a “Guild” instead. In order to be more consistent with the API documentation when necessary, the model has been renamed to Guild and all instances referring to it has been changed as well.

@Bakersbakebread
Copy link
Contributor

I think it was decided that guild was to be used in the back end, and server in front.

@bobloy bobloy mentioned this pull request Apr 16, 2018
3 tasks
@palmtree5
Copy link
Member

Discord calls them servers in their own UI while the API docs refer to them as guilds. Thus, I think it makes sense that they should be referred to as servers with regards to user-facing output and as guilds otherwise

@palmtree5 palmtree5 merged commit 705d9b8 into Cog-Creators:V3/develop Apr 16, 2018
@bobloy bobloy deleted the guild-to-server branch May 4, 2018 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants