[V3] Cleanup loop #1533
Merged
[V3] Cleanup loop #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assorted pep8 updates to retrigger Travis
This reverts commit d0c7f8b.
palmtree5
approved these changes
Apr 16, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
If passed
numberwas greater than messages in channel, while loop would run infinitelyThis fixes #1513
Additionally, I unindented
before = messagefrom async for loopI did not see a purpose to assign it within the for loop, but correct me if I'm wrong
This is a second pull request on the same issue, as first one ran into unrelated Travis issues