[V3 Launcher] Reinstall Red option #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kowlin
previously requested changes
Apr 16, 2018
palmtree5
previously requested changes
Apr 16, 2018
redbot/setup.py
Outdated
| @@ -287,7 +283,7 @@ def basic_setup(): | |||
| if confirm("Would you like to import your data? (y/n) "): | |||
| await json_to_mongo(current_data_dir, storage_details) | |||
| else: | |||
| storage_details = instance_data["STORAGE_DETAILS"] | |||
| storage_details = default_dirs["STORAGE_DETAILS"] | |||
There was a problem hiding this comment.
NO NO NO. This should NOT have been changed. storage_details is set to the storage details from the instance settings for a very, very good reason (the actual storage details are needed if the user wants to import from MongoDB to JSON)
There was a problem hiding this comment.
That wasn't intended. Seems that's from another PR. Removing that...
|
Fixed wrong changes. Needs testing |
removed `index: int` because what's being passed there is a string data -> instance_data
|
I recorded a video showing the features on the last commit |
Kowlin
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
This PR adds a new button in the launcher:
Reinstall Red. This is similar to the v2 option, it can reinstall requirements and discard code changes, reset data, or both. A lit of things were edited inlauncher.pyandsetup.pyto make it (mostly some features moved to a function so they can be used twice without repeating).That is not tested yet because of the packages conflict with
websocketswhich makes the update glitching. Please test it and push any changes if you're a maintainer so we can merge this before beta 12.