Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report fixes + improvements #1541

Merged
merged 12 commits into from
May 4, 2018
Merged

Report fixes + improvements #1541

merged 12 commits into from
May 4, 2018

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Apr 18, 2018 •
edited

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

  • fixes an issue with the logic of guild discovery for DM usage.

  • Allows non interactive usage

  • respects embedset

  • forwards uploads on initial report

Additional changes

  • Tunnel has been restructured with a handful of static methods provided for non persistent useage.

Looking for

  • Feedback on current usability (preferred if we have anyone currently using it, but not 100% needed)

@mikeshardmind mikeshardmind changed the title Report fixes Report fixes + improvements Apr 18, 2018
@mikeshardmind
Copy link
Contributor Author

This has the previously discussed changes, as well as a few more things for improved usability.

@palmtree5 palmtree5 added the V3 label Apr 23, 2018
@Kowlin Kowlin merged commit 7cd98c8 into Cog-Creators:V3/develop May 4, 2018
@mikeshardmind mikeshardmind deleted the report-fixes branch December 26, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kowlin Kowlin Kowlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikeshardmind @Kowlin @palmtree5